Tooltip documentation #1955
Merged
Tooltip documentation #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gus4no
force-pushed
the
tooltip-documentation
branch
from
af726c0 to
adc26f1
Compare
tvdeyen
requested changes
May 31, 2017
| @@ -106,6 +106,15 @@ | |||
| border: 1px solid darken($color-7, 10%); | |||
| } | |||
| } | |||
|
|
|||
| table { | |||
There was a problem hiding this comment.
The table needs a class otherwise all tables in the style guide will match this.
| th, td { | ||
| &.actions { | ||
| border-right: 1px solid #cee1f4 !important; | ||
| border-bottom: 1px solid #cee1f4 !important; |
There was a problem hiding this comment.
I'm ok with this as the problem is due to the original - wrong - implementation.
gus4no
force-pushed
the
tooltip-documentation
branch
from
662b292 to
52da7ea
Compare
|
Ready @tvdeyen, sorry it took long for such a simple change, hope all is good now. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1321
Adding a few extra information for tooltips.
I had to override some styling using
important!I don't really like this but....https://github.com/solidusio/solidus/blob/master/backend/app/assets/stylesheets/spree/backend/shared/_tables.scss#L36
This line is removing borders, I tried removing
!importantbut it would probably break something.